Make Bloomery recipe & WitherForgeRecipe public #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not entirely convinced this is the right solution for the problem. The builders assert certain conditions which are then assumed by the rest of the code. Exposing the constructors directly places the responsibility of those assertions into the user domain, which invalidates the assumptions. Is there no way to use the provided builders with the GroovyScript mod? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I understand why these constructors are
package-privatesince you should use the recipe builders.Yet, the reason for making these constructors public is to provide compatibility for the GroovyScript mod to add these recipes using its recipe builders.
All the best, teksturepako